-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and refactor VSCode integration #4010
Conversation
✨ Coder.com for PR #4010 deployed! It will be updated on every commit.
|
9883098
to
82acf10
Compare
Codecov Report
@@ Coverage Diff @@
## main #4010 +/- ##
==========================================
- Coverage 65.32% 0 -65.33%
==========================================
Files 36 0 -36
Lines 1883 0 -1883
Branches 380 0 -380
==========================================
- Hits 1230 0 -1230
+ Misses 555 0 -555
+ Partials 98 0 -98 Continue to review full report at Codecov.
|
82acf10
to
51abc84
Compare
51abc84
to
7580a52
Compare
7580a52
to
aa34126
Compare
cafb94c
to
22fb477
Compare
@TeffenEllis are you planning to update this, this week? |
@TeffenEllis Is the VS Code integration refactored in the manner of https://github.com/gitpod-io/openvscode-server? |
22fb477
to
2b49507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ea1a59d
to
9f4e932
Compare
9f4e932
to
49772d5
Compare
This PR addresses portions of #3835, specifically changes associated with making our modifications to upstream more aligned with their coding architecture and style. To keep this PR reviewable, a second PR based off the remaining changes in our fork branch will follow.
How to review this PR
Despite the file count, much of the changes here are linter corrections, removing duplicate interfaces, and moving existing interfaces into better documented areas. I recommend reviewing with whitespace changes disabled.