Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about 0.0.0.0 #441

Closed
wants to merge 7 commits into from
Closed

Add warning about 0.0.0.0 #441

wants to merge 7 commits into from

Conversation

nol166
Copy link
Contributor

@nol166 nol166 commented Apr 5, 2019 •
edited
Loading

Describe in detail the problem you had and how this PR fixes it

If 0.0.0.0 is a bad idea, this sets the default to 127.0.0.1

Is there an open issue you can link to?

#440

@nol166 nol166 changed the title packages/server/src/cli.ts Default host Apr 5, 2019
coadler
coadler reviewed Apr 5, 2019
View reviewed changes
@MichaelDesantis MichaelDesantis mentioned this pull request Apr 5, 2019
Closed
kirintwn
kirintwn reviewed Apr 8, 2019
View reviewed changes
@sr229
Copy link
Contributor

sr229 commented Apr 8, 2019

LGTM

kirintwn
kirintwn approved these changes Apr 9, 2019
View reviewed changes
Copy link

@kirintwn kirintwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sr229
sr229 approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, here's a little suggestion for UX reasons

@kirintwn kirintwn mentioned this pull request Apr 10, 2019
Closed
@nol166 nol166 changed the title Default host Add warning about 0.0.0.0 Apr 15, 2019
kylecarbs
kylecarbs requested changes Apr 17, 2019
View reviewed changes
@nol166 nol166 requested a review from kylecarbs April 22, 2019 16:49
@code-asher
Copy link
Member

Closed in favor of #857.

@code-asher code-asher closed this Jul 18, 2019
@code-asher code-asher deleted the default-host branch July 18, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler left review comments

@MichaelDesantis MichaelDesantis MichaelDesantis left review comments

@DAcodedBEAT DAcodedBEAT DAcodedBEAT approved these changes

@kirintwn kirintwn kirintwn approved these changes

@sr229 sr229 sr229 approved these changes

@code-asher code-asher Awaiting requested review from code-asher

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nol166 @sr229 @code-asher @DAcodedBEAT @coadler @kylecarbs @kirintwn @MichaelDesantis