Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test for hash with empty string #4814

Merged
merged 2 commits into from
Feb 3, 2022
Merged

feat: add test for hash with empty string #4814

merged 2 commits into from
Feb 3, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 31, 2022 •
edited
Loading

This PR adds an additional test for the hash function.

Fixes N/A

#TestingMondays

@jsjoeio jsjoeio added the testing Anything related to testing label Jan 31, 2022
@jsjoeio jsjoeio added this to the 4.0.3 milestone Jan 31, 2022
@jsjoeio jsjoeio self-assigned this Jan 31, 2022
@jsjoeio jsjoeio requested a review from a team January 31, 2022 23:12
@jsjoeio jsjoeio temporarily deployed to CI January 31, 2022 23:12 Inactive
@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

✨ Coder.com for PR #4814 deployed! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Jan 31, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@fd643dc). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4814   +/-   ##
=======================================
  Coverage        ?   69.25%           
=======================================
  Files           ?       29           
  Lines           ?     1649           
  Branches        ?      363           
=======================================
  Hits            ?     1142           
  Misses          ?      430           
  Partials        ?       77
Impacted Files Coverage Δ
src/node/util.ts 82.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd643dc...6db1ac2. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to CI February 3, 2022 19:53 Inactive
@jsjoeio jsjoeio changed the title feat: add test for hash when error feat: add test for hash with empty string Feb 3, 2022
jsjoeio
jsjoeio commented Feb 3, 2022
View reviewed changes
src/node/util.ts
Comment on lines -160 to -165
try {
return await argon2.hash(password)
} catch (error: any) {
logger.error(error)
return ""
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✍🏼 as discussed with @code-asher, this will only throw if you throw in something other than string (like number). Since TS will prevent that, we don't need the try/catch block.

@jsjoeio jsjoeio temporarily deployed to CI February 3, 2022 20:54 Inactive
code-asher
code-asher approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jsjoeio jsjoeio merged commit 00224fa into main Feb 3, 2022
@jsjoeio jsjoeio deleted the jsjoeio-hash-test branch February 3, 2022 21:22
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
@jsjoeio @TinLe
feat: add test for hash when error (coder#4814)
22a79cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
testing Anything related to testing
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @code-asher