-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): refactor build workflow #5572
Conversation
This test was really added to in get cover specific lines but it's buggy and only passes sometimes locally. I think it's okay to remove because: - it's an implementation detail (not user facing) - not preventing any specific regressions
This seems more appropriate given this tests how a plugin might work within code-server.
This reverts commit 13286bf.
This reverts commit 6c87b54.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5572 +/- ##
=======================================
Coverage 72.44% 72.44%
=======================================
Files 30 30
Lines 1673 1673
Branches 366 366
=======================================
Hits 1212 1212
Misses 398 398
Partials 63 63 Continue to review full report at Codecov.
|
25c62ca
to
77adf7b
Compare
This reverts commit 158c64d.
Looks like the cancel action workflow can't run on forks due to secrets. See andymckay/cancel-action#4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I am going to run it on my branch again to double check the changed files stuff then will approve.
- name: Run integration tests on standalone release | ||
run: yarn test:integration | ||
- name: Run native module tests on standalone release | ||
run: yarn test:native |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the rename.
The installation tests are failing but I think it is due to an older change, not this PR. I will push up a PR after this merges to fix it. I am getting lint and build errors but I am not sure why...maybe unrelated to this PR? Investigating. The Typescript lint check seems to run every time now? |
False alarm on the lint step, I thought the changed files worked from commit to next commit but I think it compares to I think we might need
|
Nice!
Ah interesting. If understanding right, you want me to add that to every step in |
Only on the steps with the |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My build issues seem to have disappeared so maybe it was a cache issue? If it crops up again we can take another look but I think we are good to go. Nicely done!
This PR does some major refactoring to our
build.yaml
workflow, specifically theprebuild
step. The two themes of this PR are:It splits up the prebuild jobs - lint, format, etc - and runs them in separate jobs so they can run in parallel. It also adds a new step to each which cancels the entire workflow if any of them fail. This way, we can fail-fast and not waste developer time or CI minutes. Plus, it allows us to run these prebuild checks in parallel to building code-server which means faster feedback loop.
Fixes N/A