Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Code to 1.81.0 #6369

Closed
wants to merge 3 commits into from
Closed

Update Code to 1.81.0 #6369

wants to merge 3 commits into from

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Aug 4, 2023

@benz0li benz0li requested a review from a team as a code owner August 4, 2023 11:02
@benz0li
Copy link
Contributor Author

benz0li commented Aug 4, 2023

code-server-4.17.0-rc.1-linux-amd64.tar.gz is deployed at https://coder.jupyter.b-data.ch; Image R (base:test-devtools-docker).

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • webview

Jupyter Notebooks also work fine:

  • ms-toolsai.jupyter@2023.3.100
  • ms-python.python@2023.12.0

@benz0li
Copy link
Contributor Author

benz0li commented Aug 4, 2023

Notable commits affecting patches:

@code-asher
Copy link
Member

Thank you! I am not sure why CI keeps requiring approval; I thought we had that for first-time contributors only so we will have to look into that.

Seems CI is experiencing a build error, I have not looked into it yet but I am going to re-run it in case it is ephemeral.

@code-asher
Copy link
Member

Re-running did not work, and it fails for me locally as well. I wonder if there is some newly required dependency.

@benz0li
Copy link
Contributor Author

benz0li commented Aug 8, 2023

Re-running did not work, and it fails for me locally as well. I wonder if there is some newly required dependency.

The problem:

make: Entering directory '/home/runner/work/code-server/code-server/lib/vscode/remote/node_modules/kerberos/build'
  CXX(target) Release/obj.target/kerberos/src/kerberos.o
In file included from ../src/kerberos_common.h:5,
                 from ../src/kerberos.h:12,
                 from ../src/kerberos.cc:1:
../src/unix/kerberos_gss.h:21:14: fatal error: gssapi/gssapi.h: No such file or directory
   21 |     #include <gssapi/gssapi.h>
      |              ^~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [kerberos.target.mk:114: Release/obj.target/kerberos/src/kerberos.o] Error 1

@code-asher Is libkrb5-dev installed?

@code-asher
Copy link
Member

Thank you, libkrb5-dev did the trick! I suppose we will need to update CI and the docs.

@benz0li
Copy link
Contributor Author

benz0li commented Aug 9, 2023

ℹ️ Prerequisites for Linux have recently changed.

@benz0li
Copy link
Contributor Author

benz0li commented Aug 9, 2023

For the next release candidate and the release itself, I recommend waiting for Code 1.81.1.

@benz0li
Copy link
Contributor Author

benz0li commented Aug 9, 2023

@code-asher Please update the CI and the docs in the meantime.

Thank you.

@code-asher
Add krb5 dependency
e7dd117 
I think we should change the docs to just link to VS Code at some point
instead of copying the apt commands, including in all the other various
places we do it.  For now I only updated CI, the flake, and the Linux
instructions under contributing but others might need updating like npm
and maybe Termux.  We have too many apt instructions scattered
everywhere, I think.
@code-asher
Increase build timeout again
0408668 
We are timing out again.
@benz0li benz0li mentioned this pull request Aug 11, 2023
Closed
@benz0li benz0li closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benz0li @code-asher