Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Change config directory from .config to .local #6419

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

bdsoha
Copy link
Contributor

@bdsoha bdsoha commented Sep 3, 2023

Updated docker documentation to use correct path locations.

@code-asher
Copy link
Member

I wonder if we want both? .config contains a config.yaml file code-server reads on startup.

@bdsoha
Copy link
Contributor Author

bdsoha commented Sep 6, 2023

I wonder if we want both? .config contains a config.yaml file code-server reads on startup.

I personally moved the file to /etc/coder/config.yaml to better conform with Linux conventions.

@code-asher
Copy link
Member

code-asher commented Sep 7, 2023

Fair, but /etc configuration tends to be world-readable and the config.yaml may contain a password.

@bdsoha
Copy link
Contributor Author

bdsoha commented Sep 7, 2023

Fair, but /etc configuration tends to be world-readable and the config.yaml may contain a password.

I agree with your comment.
For my specific orchestration, the password is not contained in the config file.

@code-asher
Copy link
Member

code-asher commented Sep 8, 2023

Makes sense! For the installation doc example what do you think about keeping the -v "$HOME/.config:/home/coder/.config" \ but also adding -v "$HOME/.local:/home/coder/.local" \ so both the config and data are persisted outside the container?

@code-asher
Copy link
Member

code-asher commented Sep 8, 2023

Since there is a comment above about .config we may want to make mention of what .local is as well.

@bdsoha
Copy link
Contributor Author

bdsoha commented Sep 10, 2023

Makes sense! For the installation doc example what do you think about keeping the -v "$HOME/.config:/home/coder/.config" \ but also adding -v "$HOME/.local:/home/coder/.local" \ so both the config and data are persisted outside the container?

VSCode doesn't use both paths.
If your goal is to also externally store and mount user-configs and user-packages, then yes.
Otherwise, IMO, I would just stick with the relevant path where VSCode's settings.json is stored.

@code-asher
Copy link
Member

VSCode doesn't use both paths.

Right, but code-server does.

Is there a situation where you would not want to mount that config when copy-pasting this command? Not doing so means that every time you restart the container your config is reset and a new password is generated.

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@code-asher code-asher merged commit 020f280 into coder:main Sep 23, 2023
9 checks passed
@bdsoha bdsoha deleted the patch-2 branch September 23, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants