-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-compose file as example #680
Conversation
With docker-compose, would it be trivial to add https with certbot for example purposes ? |
It could be easy, but I don't think it is in the scope of the example. The goal was to reproduce the docker command in the README:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should also mount the extension directorys so they get persisted
docker-compose.yml
Outdated
- "${PWD}:/home/coder/project" | ||
environment: | ||
PASSWORD: ${PASSWORD} | ||
command: --allow-http --no-auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have PASSWORD
env var, but it will not work, because the --no-auth
flag is set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add a comment here indicating that you need to remove --no-auth with a docker-compose override file or edit this one if you want to use $PASSWORD.
Obsoleted by GH-857. Please rebase this to the newer tree. |
@sr229 why is this obsolete? There is no merge conflict. |
I manually changed it to v2 flags. I'll work on this so it can be merged. |
use has been deprecated for a while now.
CC @code-asher feel free to merge this in or cherrypick. |
Describe in detail the problem you had and how this PR fixes it
There wasn't an example of how to use
docker-compose
with code-server.Is there an open issue you can link to?
Yes. docker-compose examples #648
Fixes #648.