[toolbox] Add workspace actions #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
asher/toolbox-dev/workspace-actions
branch
2 times, most recently
from
11700bd to
73f9e72
Compare
code-asher
changed the base branch from
asher/toolbox
to
asher/toolbox-dev/ci
code-asher
force-pushed
the
asher/toolbox-dev/workspace-actions
branch
from
73f9e72 to
36d871a
Compare
Qodana Community for JVM16 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.3.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
bcpeinhardt
approved these changes
Sep 24, 2024
You can now start, stop, and update workspaces. Since you can start
workspaces yourself now, I marked non-ready states as unreachable, which
prevents JetBrains from overriding with their own text ("disconnected"
and "connected"). So now you will be able to see "stopped", "starting",
and so on. For the ready states you will still see "disconnected" or
"connected" unfortunately. Ideally this would be a completely separate
state displayed next to the workspace state.
code-asher
force-pushed
the
asher/toolbox-dev/workspace-actions
branch
from
36d871a to
5e52f91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now start, stop, and update workspaces. Since you can start workspaces yourself now, I marked non-ready states as unreachable, which prevents JetBrains from overriding with their own text ("disconnected" and "connected"). So now you will be able to see "stopped", "starting", and so on, which is nice. For the ready states you will still see "disconnected" or "connected" unfortunately. Ideally this would be displayed separately from the workspace state. This also means you have two clicks instead of one to connect to a workspace, but I felt like it was worth the tradeoff to (mostly) see the actual workspace state, and it does match the current Gateway flow. If we can separate the states visually then we can bring back the one-click behavior.
Weirdly, you can still press connect when environments are unreachable, but this will not actually work. It does not actually even attempt to connect, because if it did the workspace would start via the cli, so it seems to just be a no-op. Not sure what the idea here is, we may have to consult JetBrains.
Stacked on #487, for the CI fixes.
Closes #485