-
Notifications
You must be signed in to change notification settings - Fork 48
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(jfrog): support multiple repositories (#289)
Co-authored-by: bsouza <BSouza@Acadian-Asset.com> Co-authored-by: Muhammad Atif Ali <atif@coder.com>
- Loading branch information
3 people
authored
Sep 27, 2024
1 parent
94e126f
commit ad1189a
Showing
14 changed files
with
508 additions
and
168 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| email=${ARTIFACTORY_EMAIL} | ||
| %{ for REPO in REPOS ~} | ||
| ${REPO.SCOPE}registry=${JFROG_URL}/artifactory/api/npm/${REPO.NAME} | ||
| //${JFROG_HOST}/artifactory/api/npm/${REPO.NAME}/:_authToken=${ARTIFACTORY_ACCESS_TOKEN} | ||
| %{ endfor ~} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,129 @@ | ||
| import { serve } from "bun"; | ||
| import { describe } from "bun:test"; | ||
| import { describe, expect, it } from "bun:test"; | ||
| import { | ||
| createJSONResponse, | ||
| findResourceInstance, | ||
| runTerraformInit, | ||
| runTerraformApply, | ||
| testRequiredVariables, | ||
| } from "../test"; | ||
|
|
||
| describe("jfrog-oauth", async () => { | ||
| type TestVariables = { | ||
| agent_id: string; | ||
| jfrog_url: string; | ||
| package_managers: string; | ||
|
|
||
| username_field?: string; | ||
| jfrog_server_id?: string; | ||
| external_auth_id?: string; | ||
| configure_code_server?: boolean; | ||
| }; | ||
|
|
||
| await runTerraformInit(import.meta.dir); | ||
|
|
||
| testRequiredVariables(import.meta.dir, { | ||
| agent_id: "some-agent-id", | ||
| jfrog_url: "http://localhost:8081", | ||
| package_managers: "{}", | ||
| const fakeFrogApi = "localhost:8081/artifactory/api"; | ||
| const fakeFrogUrl = "http://localhost:8081"; | ||
| const user = "default"; | ||
|
|
||
| it("can run apply with required variables", async () => { | ||
| testRequiredVariables<TestVariables>(import.meta.dir, { | ||
| agent_id: "some-agent-id", | ||
| jfrog_url: fakeFrogUrl, | ||
| package_managers: "{}", | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| //TODO add more tests | ||
| it("generates an npmrc with scoped repos", async () => { | ||
| const state = await runTerraformApply<TestVariables>(import.meta.dir, { | ||
| agent_id: "some-agent-id", | ||
| jfrog_url: fakeFrogUrl, | ||
| package_managers: JSON.stringify({ | ||
| npm: ["global", "@foo:foo", "@bar:bar"], | ||
| }), | ||
| }); | ||
| const coderScript = findResourceInstance(state, "coder_script"); | ||
| const npmrcStanza = `cat << EOF > ~/.npmrc | ||
| email=${user}@example.com | ||
| registry=http://${fakeFrogApi}/npm/global | ||
| //${fakeFrogApi}/npm/global/:_authToken= | ||
| @foo:registry=http://${fakeFrogApi}/npm/foo | ||
| //${fakeFrogApi}/npm/foo/:_authToken= | ||
| @bar:registry=http://${fakeFrogApi}/npm/bar | ||
| //${fakeFrogApi}/npm/bar/:_authToken= | ||
| EOF`; | ||
| expect(coderScript.script).toContain(npmrcStanza); | ||
| expect(coderScript.script).toContain( | ||
| 'jf npmc --global --repo-resolve "global"', | ||
| ); | ||
| expect(coderScript.script).toContain( | ||
| 'if [ -z "YES" ]; then\n not_configured npm', | ||
| ); | ||
| }); | ||
|
|
||
| it("generates a pip config with extra-indexes", async () => { | ||
| const state = await runTerraformApply<TestVariables>(import.meta.dir, { | ||
| agent_id: "some-agent-id", | ||
| jfrog_url: fakeFrogUrl, | ||
| package_managers: JSON.stringify({ | ||
| pypi: ["global", "foo", "bar"], | ||
| }), | ||
| }); | ||
| const coderScript = findResourceInstance(state, "coder_script"); | ||
| const pipStanza = `cat << EOF > ~/.pip/pip.conf | ||
| [global] | ||
| index-url = https://${user}:@${fakeFrogApi}/pypi/global/simple | ||
| extra-index-url = | ||
| https://${user}:@${fakeFrogApi}/pypi/foo/simple | ||
| https://${user}:@${fakeFrogApi}/pypi/bar/simple | ||
| EOF`; | ||
| expect(coderScript.script).toContain(pipStanza); | ||
| expect(coderScript.script).toContain( | ||
| 'jf pipc --global --repo-resolve "global"', | ||
| ); | ||
| expect(coderScript.script).toContain( | ||
| 'if [ -z "YES" ]; then\n not_configured pypi', | ||
| ); | ||
| }); | ||
|
|
||
| it("registers multiple docker repos", async () => { | ||
| const state = await runTerraformApply<TestVariables>(import.meta.dir, { | ||
| agent_id: "some-agent-id", | ||
| jfrog_url: fakeFrogUrl, | ||
| package_managers: JSON.stringify({ | ||
| docker: ["foo.jfrog.io", "bar.jfrog.io", "baz.jfrog.io"], | ||
| }), | ||
| }); | ||
| const coderScript = findResourceInstance(state, "coder_script"); | ||
| const dockerStanza = ["foo", "bar", "baz"] | ||
| .map((r) => `register_docker "${r}.jfrog.io"`) | ||
| .join("\n"); | ||
| expect(coderScript.script).toContain(dockerStanza); | ||
| expect(coderScript.script).toContain( | ||
| 'if [ -z "YES" ]; then\n not_configured docker', | ||
| ); | ||
| }); | ||
|
|
||
| it("sets goproxy with multiple repos", async () => { | ||
| const state = await runTerraformApply<TestVariables>(import.meta.dir, { | ||
| agent_id: "some-agent-id", | ||
| jfrog_url: fakeFrogUrl, | ||
| package_managers: JSON.stringify({ | ||
| go: ["foo", "bar", "baz"], | ||
| }), | ||
| }); | ||
| const proxyEnv = findResourceInstance(state, "coder_env", "goproxy"); | ||
| const proxies = ["foo", "bar", "baz"] | ||
| .map((r) => `https://${user}:@${fakeFrogApi}/go/${r}`) | ||
| .join(","); | ||
| expect(proxyEnv["value"]).toEqual(proxies); | ||
|
|
||
| const coderScript = findResourceInstance(state, "coder_script"); | ||
| expect(coderScript.script).toContain( | ||
| 'jf goc --global --repo-resolve "foo"', | ||
| ); | ||
| expect(coderScript.script).toContain( | ||
| 'if [ -z "YES" ]; then\n not_configured go', | ||
| ); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| [global] | ||
| index-url = https://${ARTIFACTORY_USERNAME}:${ARTIFACTORY_ACCESS_TOKEN}@${JFROG_HOST}/artifactory/api/pypi/${try(element(REPOS, 0), "")}/simple | ||
| extra-index-url = | ||
| %{ for REPO in try(slice(REPOS, 1, length(REPOS)), []) ~} | ||
| https://${ARTIFACTORY_USERNAME}:${ARTIFACTORY_ACCESS_TOKEN}@${JFROG_HOST}/artifactory/api/pypi/${REPO}/simple | ||
| %{ endfor ~} |
Oops, something went wrong.