fix: ensure Terraform is available for integration tests #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
changed the title
Parkreiner
commented
Jan 27, 2025
Comment on lines
+26
to
+30
| # We're using the latest version of Bun for now, but it might be worth | ||
| # reconsidering. They've pushed breaking changes in patch releases | ||
| # that have broken our CI. | ||
| # Our PR where issues started to pop up: https://github.com/coder/modules/pull/383 | ||
| # The Bun PR that broke things: https://github.com/oven-sh/bun/pull/16067 |
There was a problem hiding this comment.
Wanted to get this added to the file so that there's a paper trail in case Bun's changes suddenly cause CI to break again
|
Merging to unblock a few community PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #389
Changes made
process.envexplicitly, and pass it to our child processesNotes
spawnfunction, while also (1) pushing it out in a patch release, and (2) making no mention of the changes in their changelog. I'm not sure if we want to tighten up our Bun versioning going forward, but we can always do that in a later PR