Skip to content
This repository has been archived by the owner on Jan 17, 2021. It is now read-only.

Make releases executable #41

Closed
nol166 opened this issue Apr 22, 2019 · 5 comments · Fixed by #43
Closed

Make releases executable #41

nol166 opened this issue Apr 22, 2019 · 5 comments · Fixed by #43
Assignees
@ammario

Comments

@nol166
Copy link

nol166 commented Apr 22, 2019 •
edited
Loading

At least on Mac, it requires chmod +x to run
@nol166 nol166 changed the title make releases executable Make releases executable Apr 22, 2019
@ammario
Copy link
Member

ammario commented Apr 22, 2019

AFAIK browsers have no support for specifying file permissions for downloads.

@nol166 nol166 closed this as completed Apr 22, 2019
@nhooyr
Copy link
Contributor

nhooyr commented Apr 22, 2019

We should distribute a tar.

@nhooyr nhooyr reopened this Apr 22, 2019
@ammario
Copy link
Member

ammario commented Apr 22, 2019

Is the tar extract better than the chmod +x ?

@nhooyr
Copy link
Contributor

nhooyr commented Apr 22, 2019

Its more automated. E.g. on macOS, I can just click the icon and it auto extracts it for me with the right perms on it. Don't have to think about it or get confused when I can't execute it.

Its just more obvious how to get it to work.

@ammario
Copy link
Member

ammario commented Apr 22, 2019

That's fair. On Linux I'm in the terminal no matter what. I'll get a tar release going.

@ammario ammario self-assigned this Apr 22, 2019
ammario added a commit that referenced this issue Apr 22, 2019
@ammario
Build tar release instead of binary
093c430 
Resolves #41
@ammario ammario mentioned this issue Apr 22, 2019
Merged
ammario added a commit that referenced this issue Apr 22, 2019
@ammario
Build tar release instead of binary
a606829 
Resolves #41
@n1ru4l n1ru4l mentioned this issue Jun 29, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ammario ammario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build tar release instead of binary coder/sshcode
3 participants
@nol166 @ammario @nhooyr