This repository has been archived by the owner on Jan 17, 2021. It is now read-only.
Windows #118
Closed
Windows #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
suggested changes
Jun 15, 2019
| @@ -56,9 +56,10 @@ func sshCode(host, dir string, o options) error { | |||
| dlScript := downloadScript(codeServerPath) | |||
|
|
|||
| // Downloads the latest code-server and allows it to be executed. | |||
| sshCmdStr := fmt.Sprintf("ssh %v %v '/usr/bin/env bash'", o.sshFlags, host) | |||
| // sshCmdStr := fmt.Sprintf("ssh %v %v /bin/bash -l", o.sshFlags, host) | |||
| sshCmdStr := fmt.Sprintf("ssh %v %v '/usr/bin/env bash -l'", o.sshFlags, host) | |||
There was a problem hiding this comment.
The login shell stuff should be in a separate PR as it's unrelated to Git Bash for Windows support.
|
|
||
| sshCmd := exec.Command("sh", "-c", sshCmdStr) | ||
| sshCmd := exec.Command("sh", "-l", "-c", sshCmdStr) |
There was a problem hiding this comment.
SSH is called from more places than just this, so if we're going to change sh to a login shell so it reads the profile we should also do this every else.
|
Closing this one to submit two separate PR's. Thanks for comments. |
Open
This was referenced Jul 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.profile