Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coder_git_auth data source #100

Merged
merged 1 commit into from
Feb 22, 2023
Merged

feat: add coder_git_auth data source #100

merged 1 commit into from
Feb 22, 2023

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Feb 22, 2023

This data source enables template authors to require git authentication for specific providers on workspace build.

In Coder, we'll parse these when creating a template version and validate Git authentication before initiating a workspace build.

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pointed 2 nit-picks, but it LGTM.

@@ -0,0 +1,22 @@
provider "coder" {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty line

Comment on lines 6 to 12
"github.com/coder/terraform-provider-coder/provider"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
"github.com/stretchr/testify/require"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: mixed imports

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, ty

This data source enables template authors to require git
authentication for specific providers on workspace build.
@kylecarbs kylecarbs merged commit 101f35b into main Feb 22, 2023
@kylecarbs kylecarbs deleted the gitauth branch February 22, 2023 22:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants