Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add devcontainer config #228

Merged
merged 3 commits into from
May 23, 2024
Merged

chore: add devcontainer config #228

merged 3 commits into from
May 23, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented May 23, 2024 •
edited
Loading

For convenience!

@johnstcn johnstcn self-assigned this May 23, 2024
@johnstcn johnstcn requested review from mafredri and mtojek May 23, 2024 11:31
mafredri
mafredri reviewed May 23, 2024
View reviewed changes
.devcontainer/devcontainer.json
@@ -0,0 +1,9 @@
{
"name": "terraform-provider-coder",
"image": "mcr.microsoft.com/devcontainers/go:1.20",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still use Go 1.20 here, btw? Should we match coder/coder or go 1.22? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#222

@johnstcn johnstcn merged commit 2642fa5 into main May 23, 2024
11 checks passed
@johnstcn johnstcn deleted the cj/devcontainer branch May 23, 2024 11:45
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mafredri