Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coder_workspace_owner datasource #230

Merged
merged 5 commits into from
May 24, 2024
Merged

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented May 23, 2024

NOTE: still needs some coder/coder changes.

Adds a coder_workspace_owner data source populated from all available information, if present.

Deprecates relevant fields of coder_workspace.

@johnstcn johnstcn self-assigned this May 23, 2024
@johnstcn johnstcn force-pushed the cj/datasource_coder_user branch from 1b8e938 to 28bab5a Compare May 24, 2024 08:25
@johnstcn johnstcn marked this pull request as ready for review May 24, 2024 08:52
@johnstcn johnstcn requested review from mafredri and mtojek May 24, 2024 08:52
provider/provider.go Outdated Show resolved Hide resolved
@johnstcn johnstcn changed the title feat: add coder_user datasource feat: add coder_workspace_owner datasource May 24, 2024
provider/provider.go Outdated Show resolved Hide resolved
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although deprecation path will be long...

@johnstcn johnstcn merged commit eb43b9f into main May 24, 2024
12 checks passed
@johnstcn johnstcn deleted the cj/datasource_coder_user branch May 24, 2024 13:48
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
@matifali
Copy link
Member

@stirby if we are planning to remove all deprecated items in 1.0 then I suggest we should list them in a milestone or an ☔ issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants