-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): move coder_parameter example #243
Conversation
@mtojek I removed the
Since I couldn't find any errors in the output of
I also tried to add other resources to the All this said, I would actually like to take a stab at rewriting the Mind taking a look? |
For now, lazily duplicated resource examples test loop for data sources to test. |
Alright, I think I made the CI happy now.
This may not be straightforward if examples depend on external fields or providers. For instance: EDIT: Let me know if this is ready to review, and I will re-check everything 👍 |
I did some reading of other providers. Rarely do code examples reference other providers but it feels essential for our examples like
Edit: trying one more thing. |
Ended up over complicating. Should be good for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The
coder_parameter
data-source's code example was in the resources directory by mistake, moved.Fixes #242.
Curious what the failed
examples_test.go
looks like so intentionally ignored.