Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include deprecation message in docs #245

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jun 26, 2024

Fixes: #237

This PR adds a script to patch Terraform docs to contain the deprecation message.

@mtojek mtojek self-assigned this Jun 26, 2024
@mtojek mtojek requested a review from johnstcn June 26, 2024 08:36
@mtojek mtojek marked this pull request as ready for review June 26, 2024 08:36
@mtojek mtojek requested a review from stirby June 26, 2024 08:36
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out!
Just a couple of small changes I'd like to see in the docsgen script to make it easier to debug changes in future.

scripts/docsgen/main.go Outdated Show resolved Hide resolved
scripts/docsgen/main.go Show resolved Hide resolved
scripts/docsgen/main.go Outdated Show resolved Hide resolved
@mtojek mtojek merged commit dd5f55c into main Jun 26, 2024
12 checks passed
@mtojek mtojek deleted the 237-deprecation-message branch June 26, 2024 09:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs missing deprecation notice and migration steps
2 participants