Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify coder_metadata usage #267

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Aug 14, 2024

The coder_metadata resource is only used to apply metadata to specific template resources. To apply metadata at the workspace level, and have it be shown on the main workspace pane, a metadata block needs to be created on the coder_agent resource. Alternatively, any coder_metadata attached to the resource containing the agent will be shown on the dashboard by default (see our dogfood template), but this isn't super obvious, so we'll add a comment.

It's pretty easy to assume that the coder_metadata resource would let you apply workspace metadata, if you associated it with the agent, so we'll also add a comment mentioning this isn't the case.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson marked this pull request as ready for review August 14, 2024 04:16
@ethanndickson ethanndickson force-pushed the 08-14-docs_clarify_coder_metadata_usage branch from 19dd470 to 38546ea Compare August 14, 2024 04:17
@ethanndickson ethanndickson force-pushed the 08-14-docs_clarify_coder_metadata_usage branch 2 times, most recently from ff7aabf to 97e4fb5 Compare August 14, 2024 05:30
@ethanndickson ethanndickson force-pushed the 08-14-docs_clarify_coder_metadata_usage branch from 97e4fb5 to ca52f1f Compare August 14, 2024 05:48
@matifali
Copy link
Member

Important

We should backport this to release/1.0 branch as the main currently has breaking changes.


Also, I renamed the v1-breaking milestone to v2 to track when we want to cut a 2.0 release.
cc: @stirby

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanndickson @stirby can you backport this to release branch too? And then we can push a new tag.

@ethanndickson ethanndickson merged commit 286841d into main Aug 29, 2024
9 checks passed
@ethanndickson ethanndickson deleted the 08-14-docs_clarify_coder_metadata_usage branch August 29, 2024 04:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants