fix: validate agent & resource metadata keys during plan #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
ethanndickson
force-pushed
the
09-05-fix_validate_agent_resource_metadata_keys_during_plan
branch
from
6e8c7db to
b005008
Compare
johnstcn
reviewed
Sep 5, 2024
ethanndickson
force-pushed
the
09-05-fix_validate_agent_resource_metadata_keys_during_plan
branch
from
b005008 to
fdb3846
Compare
ethanndickson
force-pushed
the
09-05-fix_validate_agent_resource_metadata_keys_during_plan
branch
from
fdb3846 to
fd94956
Compare
johnstcn
approved these changes
Sep 5, 2024
ethanndickson
deleted the
09-05-fix_validate_agent_resource_metadata_keys_during_plan
branch
|
Do we want to port this to |
|
Yeah, potentially. What are the breaking changes on main not included in any release? I'm not familiar |
|
We removed a couple of deprecated resources and attributes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/coder#14387.
Closes coder/coder#14569.
Previously, the configuration had to be applied in order for the provider to complain about duplicate keys - now just a plan will suffice.