Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional everyone group in integration test #278

Merged

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Sep 5, 2024

CI is currently failing and blocking PRs as the integration test running against Coder v2.15.0 (mainline) adds the "Everyone" group to the workspace_owner groups field. However, the CI also runs the integration test against Coder v2.14.2 (stable), which doesn't include the everyone group.

We'll accept either an empty groups list, or a list with the everyone group to enable running the test against both versions.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson marked this pull request as ready for review September 5, 2024 15:19
@ethanndickson ethanndickson self-assigned this Sep 5, 2024
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ethanndickson ethanndickson merged commit 5f660a0 into main Sep 5, 2024
9 checks passed
@ethanndickson ethanndickson deleted the 09-05-fix_optional_everyone_group_in_integration_test branch September 5, 2024 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants