Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go to 1.18, k8s to 0.24.2 #393

Merged
merged 16 commits into from
Dec 5, 2022
Merged

Update go to 1.18, k8s to 0.24.2 #393

merged 16 commits into from
Dec 5, 2022

Conversation

ranakan19
Copy link
Contributor

No description provided.

@ranakan19 ranakan19 mentioned this pull request Nov 24, 2022
Merged
@codecov
Copy link

codecov bot commented Nov 24, 2022 •
edited

Codecov Report

Merging #393 (627a824) into master (c0c031f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files          25       25           
  Lines        3083     3083           
=======================================
  Hits         2535     2535           
  Misses        415      415           
  Partials      133      133

xcoulon
xcoulon reviewed Nov 25, 2022
View reviewed changes
config/crd/bases/toolchain.dev.openshift.com_idlers.yaml
@@ -118,9 +118,3 @@ spec:
storage: true
subresources:
status: {}
status:
Copy link
Contributor

@xcoulon xcoulon Nov 25, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why all the status sections have been removed by controller-gen in these YAML files 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xcoulon yes, i was thinking the same. For reference - kubernetes-sigs/controller-tools#630 - explains a bit more about the choice of removing status.

mfrancisc
mfrancisc reviewed Dec 2, 2022
View reviewed changes
go.mod Outdated

replace (
github.com/codeready-toolchain/api v0.0.0-20221121081259-4f672e808b89 => github.com/ranakan19/api v0.0.0-20221201091806-57fc665ce345
github.com/codeready-toolchain/toolchain-common v0.0.0-20221117081323-252a38460fa1 => github.com/ranakan19/toolchain-common v0.0.0-20221201182049-e9ceb160687f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

friendly reminder!

@ranakan19
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, mfrancisc, ranakan19, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xcoulon
go mod update/replace + codecov token
627a824 
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@xcoulon xcoulon merged commit 490f9c3 into codeready-toolchain:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcoulon xcoulon xcoulon approved these changes

@MatousJobanek MatousJobanek MatousJobanek approved these changes

@mfrancisc mfrancisc mfrancisc approved these changes

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov alexeykazakov is a code owner

@michaelkleinhenz michaelkleinhenz Awaiting requested review from michaelkleinhenz

@sbryzak sbryzak Awaiting requested review from sbryzak sbryzak is a code owner

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ranakan19 @xcoulon @MatousJobanek @mfrancisc @openshift-merge-robot