Improve error handling of transaction::commit_or_rollback_by_xid() #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciascid
force-pushed
the
unknown_xid
branch
from
6b4937d to
f27b4cf
Compare
Handle the case where a call to commit_or_rollback_by_xid() is given a xid for which there is no corresponding streaming applier. We distinguish two cases here: 1) the xid might not exist at all, or the corresponding transaction was already committed or rolled back. The client may just return an error; or 2) all streaming appliers have been closed because the node is currently disconnected. We can't tell if a corresponding transaction exists. The client may want to retry.
sciascid
force-pushed
the
unknown_xid
branch
2 times, most recently
from
66fc9b3 to
ece5942
Compare
Handle the case where server_id is undefined in before fragment certification. This may happen if the server is disconnected right before replicating a fragment.
sciascid
force-pushed
the
unknown_xid
branch
from
ece5942 to
9db81de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case where a call to commit_or_rollback_by_xid() is given
a xid for which there is no corresponding streaming applier.
We distinguish two cases here:
was already committed or rolled back. The client may just return an
error; or 2) all streaming appliers have been closed
because the node is currently disconnected. We can't tell if a
corresponding transaction exists. The client may want to retry.