-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed background_rollback to return true/false depending on if #212
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -183,11 +183,12 @@ namespace wsrep | |
return start_sst_action(); | ||
} | ||
|
||
void | ||
bool | ||
background_rollback(wsrep::client_state& client_state) WSREP_OVERRIDE | ||
{ | ||
client_state.before_rollback(); | ||
client_state.after_rollback(); | ||
return false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe I do not understand but when this method can return true ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is for unit testing, so it does not necessarily implement all the same behavior as real application. |
||
} | ||
|
||
int wait_committing_transactions(int) WSREP_OVERRIDE { return 0; } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document the meaning of return value in comment above.