Merge pull request #282 from coderxio/requirements-install

updates to docker-compose to accomodate easy installation of new pack…
coderxio · May 13, 2024 · ec93e12 · ec93e12
2 parents fb97f2e + da72f3c
commit ec93e12
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/airflow/hidden_dags/cms_part_d_plans/cms_part_d_plans_dag.py b/airflow/hidden_dags/cms_part_d_plans/cms_part_d_plans_dag.py
@@ -2,7 +2,7 @@
 import os
 import pendulum
 # zipfile_deflate64 is needed likely because of how CMS zips these files
-import zipfile_deflate64 as zipfile
+import zipfile_deflate64 as zipfile # this package is not easily accessible in this context - consider an alternative
 
 from sagerx import create_path, get_dataset, read_sql_file, get_sql_list, alert_slack_channel
 

diff --git a/airflow/requirements.txt b/airflow/requirements.txt
@@ -1,3 +1,4 @@
-apache-airflow[amazon]
+# Any change made here should accompany an increment 
+# to the image version on line 5 of docker-compose.yml
+
 dbt-postgres==1.4.1
-zipfile_deflate64
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -2,12 +2,12 @@ version: "3.8"
 x-airflow-common: &airflow-common
   build:
     context: ./airflow
-  image: sagerx_airflow
+  image: sagerx_airflow:v0.0.1 # versioning allows a rebuild of docker image where necessary
   environment: &airflow-common-env
     AIRFLOW__CORE__EXECUTOR: LocalExecutor
     AIRFLOW__CORE__DAGS_ARE_PAUSED_AT_CREATION: "true"
     AIRFLOW__CORE__LOAD_EXAMPLES: "false"
-    #AIRFLOW__WEBSERVER__WEB_SERVER_MASTER_TIMEOUT: "300" #un-comment if gunicorn timeout reached
+    #AIRFLOW__WEBSERVER__WEB_SERVER_MASTER_TIMEOUT: "300" # un-comment if gunicorn timeout reached
     AIRFLOW__DATABASE__SQL_ALCHEMY_CONN: postgresql+psycopg2://airflow:airflow@postgres:5432/airflow
     AIRFLOW_CONN_POSTGRES_DEFAULT: postgresql://sagerx:sagerx@postgres:5432/sagerx
     AIRFLOW_VAR_UMLS_API: ${UMLS_API}