Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alow-downloads to the iframe #5163

Merged
merged 2 commits into from
Nov 23, 2020
Merged

add alow-downloads to the iframe #5163

merged 2 commits into from
Nov 23, 2020

Conversation

SaraVieira
Copy link
Contributor

@SaraVieira SaraVieira commented Nov 20, 2020

I tested in:

  • Chrome: Will block any downloads done automatically
  • Firefox and Brave: Will show you a download button and not download automatically
  • SaFari: will show a massive warning asking you if you wish to download that

If put on page load no website will download files automatically

Not added automatically to embedded since that is in control of the user

closes #4739

@SaraVieira SaraVieira changed the title add alow-downloads add alow-downloads to the iframe Nov 20, 2020
@lbogdan lbogdan temporarily deployed to pr5163 November 20, 2020 20:29 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Nov 20, 2020

Build for latest commit 17fa0af is at https://pr5163.build.csb.dev/s/new.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 17fa0af:

Sandbox Source
Notifications Test Configuration
relaxed-sutherland-esv6m Issue #4739

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@mohdashraf010897
Copy link

mohdashraf010897 commented Aug 16, 2022

@andrasbacsai The issue still persists.

Replicable CSB - https://ohpo6e.sse.codesandbox.io/

Click on any one of the given link-buttons that will let you save a CSV/ JSON file.
image

the console shows
image

Browser: Chrome (Version 104.0.5112.79 (Official Build) (x86_64))

@andrasbacsai
Copy link
Contributor

I'm not working for Codesandbox.

@JamesACS, could you please check the issue? Thanks in advance.

@JamesACS
Copy link
Contributor

@mohdashraf010897 - This issue is two years old. Please could you create a new one following the bug report template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading is disabled in Chrome in the Preview window
6 participants