Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React Refresh boundary export changes #5442

Merged
merged 5 commits into from
Feb 3, 2021

Conversation

CompuIves
Copy link
Member

@CompuIves CompuIves commented Feb 2, 2021

This PR does three things:

  1. It calls module.hot.invalidate() if the export structure of a module changes within React Refresh context
  2. It adds module.hot.invalidate functionality 🙂
  3. Stops showing Aw Snap message on Sandpack

This will make React refreshes when exports change much more stable, and will in general improve the experience for Sandpack.

@CompuIves CompuIves changed the title Fix/react refresh boundaries Fix React Refresh boundary export changes Feb 2, 2021
@lbogdan
Copy link
Contributor

lbogdan commented Feb 2, 2021

Build for latest commit c51fa14 is at https://pr5442.build.csb.dev/s/new.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c51fa14:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr5442 February 3, 2021 10:03 Inactive
@lbogdan lbogdan temporarily deployed to pr5442 February 3, 2021 12:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants