chore: refactor custom protocol #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
1cff9ef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1ad528b9.sandpack-bundler.pages.dev |
CSB-4520 Make fs protocol use the same base iFrame protocol used by the bundler
Currently the fs protocol and the base iFrame protocol used by sandpack differ immensely, causing issues like not being able to show multiple sandboxes with the same parent window reliably. |
danilowoz
approved these changes
May 31, 2022
| @@ -6,15 +6,11 @@ import { Emitter } from '../utils/emitter'; | |||
| * */ | |||
| export class IFrameParentMessageBus { | |||
| private parentId: number | null = null; | |||
| private messageId = Date.now(); | |||
| private messageId = 0; | |||
There was a problem hiding this comment.
Will this value always be 0 or will it increase on every message?
There was a problem hiding this comment.
It will increase for every message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor iFrame protocol for the custom protocols, so we can reuse the same base protocol instead of reinventing the wheel again
Closes CSB-4520