Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standardize components #376

Merged
merged 2 commits into from
Feb 25, 2022
Merged

fix: standardize components #376

merged 2 commits into from
Feb 25, 2022

Conversation

danilowoz
Copy link
Member

@danilowoz danilowoz commented Feb 17, 2022

  • Accept className props;
  • Rename customStyle to style;
  • Add proper Typescript types based on HTML element;

@github-actions
Copy link

github-actions bot commented Feb 17, 2022

Size changes

sandpack-react

Total base (gzip) Total current (gzip) +/-
161 kb 160 kb 🎉 -2 kb (-0.94%)
Details
Dependency name / file Base Current +/-
index.css 28 kb File removed ⚠️
webpack 487 bytes File removed ⚠️
0 522 kb 522 kb ✅ 0 byte
main 457 kb 477 kb ⚠️ +20 kb (+4.29%)
@codesandbox/sandpack-react 73 kb 80 kb ⚠️ +7 kb (+9.54%)
@code-hike/classer 1 kb 1 kb ✅ 0 byte
@codemirror/state 35 kb 35 kb ✅ 0 byte
@codemirror/view 165 kb 165 kb ✅ 0 byte
@codemirror/highlight 12 kb 12 kb ✅ 0 byte
@codemirror/lang-css 11 kb 11 kb ✅ 0 byte
@codemirror/lang-javascript 6 kb 6 kb ✅ 0 byte
@codemirror/lang-html 15 kb 15 kb ✅ 0 byte
@stitches/core New file 16 kb ⚠️
@codesandbox/sandpack-client 13 kb 13 kb ✅ 0 byte
@codemirror/closebrackets 6 kb 6 kb ✅ 0 byte
@codemirror/matchbrackets 4 kb 4 kb ✅ 0 byte
@codemirror/commands 24 kb 24 kb ✅ 0 byte
@codemirror/comment 5 kb 5 kb ✅ 0 byte
@codemirror/gutter 10 kb 10 kb ✅ 0 byte
@codemirror/history 9 kb 9 kb ✅ 0 byte
@react-hook/intersection-observer 2 kb 2 kb ✅ 0 byte
@lezer/common 33 kb 33 kb ✅ 0 byte
style-mod 3 kb 3 kb ✅ 0 byte
@codemirror/text 13 kb 13 kb ✅ 0 byte
@codemirror/rangeset 16 kb 16 kb ✅ 0 byte
w3c-keyname 2 kb 2 kb ✅ 0 byte
@codemirror/language 19 kb 19 kb ✅ 0 byte
@lezer/css 9 kb 9 kb ✅ 0 byte
@lezer/html 12 kb 12 kb ✅ 0 byte
@lezer/javascript 54 kb 54 kb ✅ 0 byte
@codemirror/autocomplete 34 kb 34 kb ✅ 0 byte
@react-hook/passive-layout-effect 191 bytes 191 bytes ✅ 0 byte
@lezer/lr 31 kb 31 kb ✅ 0 byte
@codemirror/tooltip 14 kb 14 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
codesandbox-import-utils 367 bytes 367 bytes ✅ 0 byte
react-devtools-inline 823 kb 823 kb ✅ 0 byte
package-build-stats New file 487 bytes ⚠️
lz-string 9 kb 9 kb ✅ 0 byte
intersection-observer 13 kb 13 kb ✅ 0 byte
react-is 2 kb 2 kb ✅ 0 byte

sandpack-client

Total base (gzip) Total current (gzip) +/-
7 kb 7 kb ✅ 0 byte
Details
Dependency name / file Base Current +/-
webpack 487 bytes File removed ⚠️
main 20 kb 21 kb ✅ 0 byte
@codesandbox/sandpack-client 11 kb 11 kb ✅ 0 byte
codesandbox-import-utils 3 kb 3 kb ✅ 0 byte
lodash.isequal 18 kb 18 kb ✅ 0 byte
package-build-stats New file 487 bytes ⚠️

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 06061a2:

Sandbox Source
Sandpack Blog Example 1 Configuration

@danilowoz danilowoz changed the title cover common components fix: standardize components Feb 25, 2022
@danilowoz danilowoz marked this pull request as ready for review February 25, 2022 13:02
@danilowoz danilowoz merged commit c4d3d85 into major-release Feb 25, 2022
@danilowoz danilowoz deleted the feat/pass-html-props branch February 25, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant