Fixing removing public holidays

server/cshr/views/vacations.py

@@ -125,6 +125,7 @@ def post(self, request: Request) -> Response:
         if serializer.is_valid():
             balance = OfficeVacationBalance.objects.filter(year=year, location=location)
             public_holidays = request.data["public_holidays"]
+
             for holiday in public_holidays:
                 PublicHoliday.objects.get_or_create(
                     location=location, holiday_date=holiday
@@ -134,6 +135,15 @@ def post(self, request: Request) -> Response:
                 location=location, holiday_date__in=public_holidays
             ).values_list("id", flat=True)
 
+            if len(public_holidays) < len(balance[0].public_holidays.all()):
+                deleted_holidays = []
+                for holiday in balance[0].public_holidays.all():
+                    if holiday.id not in public_holidays:
+                        deleted_holidays.append(holiday)
+
+                for day in deleted_holidays:
+                    PublicHoliday.objects.get(id=day.id).delete()
+
             if len(balance) > 0:
                 balance[0].annual_leaves = serializer.validated_data.get(
                     "annual_leaves"
@@ -159,6 +169,7 @@ def post(self, request: Request) -> Response:
         )
 
 
+
 class BaseVacationsApiView(ListAPIView, GenericAPIView):
     """Class Vacations_APIView to create a new vacation into database or get all"""