Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-commit issues #2967

Merged
merged 6 commits into from
Jul 25, 2023
Merged

Fix pre-commit issues #2967

merged 6 commits into from
Jul 25, 2023

Commits on Jul 25, 2023

  1. Remove a duplicate pre-commit hook

    @kurtmckee
    kurtmckee committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    62b9391 View commit details
    Browse the repository at this point in the history

  2. Satisfy check-shebang-scripts-are-executable pre-commit hook

    @kurtmckee
    kurtmckee committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    c73899d View commit details
    Browse the repository at this point in the history

  3. Satisfy mypy pre-commit hook

    @kurtmckee
    kurtmckee committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    5ed3c29 View commit details
    Browse the repository at this point in the history

  4. Run pre-commit autoupdate

    @kurtmckee
    kurtmckee committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    81ce5c2 View commit details
    Browse the repository at this point in the history

  5. Resolve mypy config discrepancies between pre-commit and CI 

    In addition, add make target, `mypy`, to run mypy locally.

The changes were tested with mypy running on Python 3.7 and Python 3.11.
    @kurtmckee
    kurtmckee committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    fc131b3 View commit details
    Browse the repository at this point in the history

  6. Resolve a missing auto-generated file import complaint from mypy

    @kurtmckee
    kurtmckee committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    9108082 View commit details
    Browse the repository at this point in the history