Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add distriute->distribute (and variations) to dictionary.txt #3517

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Add distriute->distribute (and variations) to dictionary.txt #3517

merged 1 commit into from
Sep 1, 2024

Conversation

corneliusroemer
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos added the dictionary Changes to the dictionary label Aug 18, 2024
@corneliusroemer
Copy link
Contributor Author

corneliusroemer commented Aug 18, 2024 •
edited
Loading

We could also add distributor and all the typos for it

Some more words

Word Frequency (words per million) per ngram viewer
distribution 93.38
distributed 32.19
distributions 11.13
distribute 5.52
distributive 2.25
distributes 1.11
distributorship 0.46
distributable 0.16
distributively 0.029

DimitriPapadopoulos
DimitriPapadopoulos reviewed Aug 18, 2024
View reviewed changes
codespell_lib/data/dictionary.txt Outdated
@@ -22319,12 +22319,14 @@ distintions->distinctions
distintive->distinctive
distintively->distinctively
distintly->distinctly, distantly,
distirbitive->distributive, disruptive
Copy link
Collaborator

@DimitriPapadopoulos DimitriPapadopoulos Aug 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you found actual occurrences of distirbitive as a typo of disruptive?

Suggested change
distirbitive->distributive, disruptive
distirbitive->distributive

codespell_lib/data/dictionary.txt Outdated Show resolved Hide resolved
codespell_lib/data/dictionary.txt Show resolved Hide resolved
codespell_lib/data/dictionary.txt Show resolved Hide resolved
codespell_lib/data/dictionary.txt Show resolved Hide resolved
codespell_lib/data/dictionary.txt Show resolved Hide resolved
codespell_lib/data/dictionary.txt Outdated Show resolved Hide resolved
codespell_lib/data/dictionary.txt Outdated Show resolved Hide resolved
codespell_lib/data/dictionary.txt Show resolved Hide resolved
@corneliusroemer
Copy link
Contributor Author

corneliusroemer commented Aug 18, 2024 •
edited
Loading

A github bug prevents me from merging your suggestions, I agree with them all, save the disturbative, which might appear in dictionaries, but is in practice never used:

Google Chrome 2024-08-18 23 12 03

But I'm happy to remove, doesn't matter.

See bug:

image

@DimitriPapadopoulos
Copy link
Collaborator

Yes, I'm aware of the GitHub bug on large files, after a very precise size in bytes. I had reported this bug, but it hasn't been fixed so far. Merge requests on such large text files is a niche.

@corneliusroemer
Copy link
Contributor Author

Interesting, thanks! Do you have a link to the issue or is it a private ticket?

@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Aug 20, 2024 •
edited
Loading

GitHub bugs are were not reported using GitHub issues 😄 So it's a private bug report.

@corneliusroemer
Copy link
Contributor Author

corneliusroemer commented Aug 20, 2024 •
edited
Loading

I know one can't make an issue, but one can make a GitHub discussion so that one doesn't need to report the same thing that others have already done.

See https://github.com/orgs/community/discussions/136302

(I also reported privately)

@DimitriPapadopoulos
Copy link
Collaborator

I just noticed that nowadays https://support.github.com/contact/feedback actually forwards to https://github.com/orgs/community/discussions. Raising this issue again, in a public discussion, might be a good idea.

@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Aug 20, 2024 •
edited
Loading

See #3017 (comment) for details on this bug.

@corneliusroemer @DimitriPapadopoulos
Add distriute->distribute (and variations)
f96dccc 
Co-authored-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
@DimitriPapadopoulos DimitriPapadopoulos merged commit d66030d into codespell-project:master Sep 1, 2024
15 checks passed
@DimitriPapadopoulos
Copy link
Collaborator

Thank you @corneliusroemer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitriPapadopoulos DimitriPapadopoulos DimitriPapadopoulos approved these changes

@peternewman peternewman Awaiting requested review from peternewman

Assignees
No one assigned
Labels
dictionary Changes to the dictionary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliusroemer @DimitriPapadopoulos