-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Letter 'i' from #436 #483
Letter 'i' from #436 #483
Conversation
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
=======================================
Coverage 88.77% 88.77%
=======================================
Files 3 3
Lines 704 704
Branches 100 100
=======================================
Hits 625 625
Misses 60 60
Partials 19 19 Continue to review full report at Codecov.
|
codespell_lib/data/dictionary.txt
Outdated
@@ -5807,13 +5831,19 @@ inablility->inability | |||
inacccessible->inaccessible | |||
inaccesible->inaccessible | |||
inaccessable->inaccessible | |||
inactivate->inactive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is an acceptable verb, so it should stay the first suggestion. You can also suggest "deactivate".
codespell_lib/data/dictionary.txt
Outdated
inconsistant->inconsistent | ||
inconsisten->inconsistent | ||
inconsistenly->inconsistently | ||
inconsitent->inconsistent | ||
inconstent->inconsistent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also "inconstant"
codespell_lib/data/dictionary.txt
Outdated
@@ -6043,38 +6107,51 @@ initally->initially | |||
initation->initiation | |||
initators->initiators | |||
initiaitive->initiative | |||
initiales->initialize, initializes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comma at end
codespell_lib/data/dictionary.txt
Outdated
innacurate->inaccurate | ||
innacurately->inaccurately | ||
inneffectual->ineffectual | ||
innitialize->initializes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initialize
codespell_lib/data/dictionary.txt
Outdated
invisiable->invisible | ||
invlaid->invalid | ||
invlisible->invisible | ||
invokable->invocable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invokable seems okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
codespell_lib/data/dictionary.txt
Outdated
implementatition->implementation | ||
implementatoins->implementations | ||
implementatoion->implementation | ||
implemente->implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combine with line below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@larsoner please clarify what you mean, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nvm, i see it
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
Rebased and ready for merge |
codespell_lib/data/dictionary.txt
Outdated
initialsed->initialized | ||
initialses->initializes | ||
initializong->initializing | ||
initialse->initialize, initialize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean initialise
for the second one?
https://travis-ci.org/lucasdemarchi/codespell/jobs/376840463
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
facepalm
codespell_lib/data/dictionary.txt
Outdated
initiliase->initialise, initialize, | ||
initiliased->initialised, initialized, | ||
initiliases->initialises, initializes, | ||
initiliasing->initialising, initialising, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codespell_lib/data/dictionary.txt
Outdated
initilise->initialise, initialize, | ||
initilised->initialised, initialized, | ||
initilises->initialises, initializes, | ||
initilising->initialising, initialising, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate
codespell_lib/data/dictionary.txt
Outdated
intall->install | ||
intance->instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intance
already exists
https://travis-ci.org/lucasdemarchi/codespell/jobs/376870882#L670
It's probably worth running pytest codespell_lib
locally so you don't have to wait for Travis to give this feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do I run pytest codespell_lib
?
bash: pytest: command not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to install the pytest
and pytest-cov
Python packages
Continuing to separate
#428#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.