Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter 'i' from #436 #483

Merged
merged 7 commits into from
May 10, 2018
Merged

Letter 'i' from #436 #483

merged 7 commits into from
May 10, 2018

Conversation

luzpaz
Copy link
Collaborator

@luzpaz luzpaz commented May 6, 2018

Continuing to separate #428 #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

@codecov-io
Copy link

codecov-io commented May 6, 2018

Codecov Report

Merging #483 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files           3        3           
  Lines         704      704           
  Branches      100      100           
=======================================
  Hits          625      625           
  Misses         60       60           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c56f4f...734b562. Read the comment docs.

@@ -5807,13 +5831,19 @@ inablility->inability
inacccessible->inaccessible
inaccesible->inaccessible
inaccessable->inaccessible
inactivate->inactive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is an acceptable verb, so it should stay the first suggestion. You can also suggest "deactivate".

inconsistant->inconsistent
inconsisten->inconsistent
inconsistenly->inconsistently
inconsitent->inconsistent
inconstent->inconsistent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also "inconstant"

@@ -6043,38 +6107,51 @@ initally->initially
initation->initiation
initators->initiators
initiaitive->initiative
initiales->initialize, initializes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comma at end

innacurate->inaccurate
innacurately->inaccurately
inneffectual->ineffectual
innitialize->initializes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initialize

invisiable->invisible
invlaid->invalid
invlisible->invisible
invokable->invocable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invokable seems okay

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

implementatition->implementation
implementatoins->implementations
implementatoion->implementation
implemente->implement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combine with line below

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsoner please clarify what you mean, thanks.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nvm, i see it

luzpaz added 3 commits May 9, 2018 09:45
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
@luzpaz
Copy link
Collaborator Author

luzpaz commented May 9, 2018

Rebased and ready for merge

initialsed->initialized
initialses->initializes
initializong->initializing
initialse->initialize, initialize,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean initialise for the second one?

https://travis-ci.org/lucasdemarchi/codespell/jobs/376840463

Copy link
Collaborator Author

@luzpaz luzpaz May 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

facepalm

initiliase->initialise, initialize,
initiliased->initialised, initialized,
initiliases->initialises, initializes,
initiliasing->initialising, initialising,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initilise->initialise, initialize,
initilised->initialised, initialized,
initilises->initialises, initializes,
initilising->initialising, initialising,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate

intall->install
intance->instance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intance already exists

https://travis-ci.org/lucasdemarchi/codespell/jobs/376870882#L670

It's probably worth running pytest codespell_lib locally so you don't have to wait for Travis to give this feedback

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do I run pytest codespell_lib ?
bash: pytest: command not found

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to install the pytest and pytest-cov Python packages

@larsoner larsoner merged commit aa3fbb0 into codespell-project:master May 10, 2018
@luzpaz luzpaz deleted the letter/i branch May 10, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants