Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate values with Mutliple containers #16

Open
Madhu1512 opened this issue Sep 28, 2017 · 1 comment
Open

Duplicate values with Mutliple containers #16

Madhu1512 opened this issue Sep 28, 2017 · 1 comment

Comments

@Madhu1512
Copy link

After the earlier commit's #14 #15, I started adding some of the nginx properties via environment variables. It works fine when you have one container running under nginx proxy but when you have multiple containers, values are getting duplicated.

example:

container -1:

key: NGINX_GEN_keepalive_timeout value: 120s

container -2:

key: NGINX_GEN_keepalive_timeout value: 120s

when ecs-gen writes the nginx.conf file it's adding same value twice.

server {

    server_name xxxxxxxxxxx;

    keepalive_timeout 120s;

    keepalive_timeout 120s;

    listen 80;

    access_log /var/log/nginx/access.log vhost;

    location / {

            proxy_pass http://xxxxxxxxxxx;

    }

}

How can we avoid duplication and have only one key value? I am not familiar with go html template so any help is appreciated.

@codesuki @smaclell

@codesuki
Copy link
Owner

Thanks for the report. I will have a look when I find the time. @smaclell since you know the code well, maybe you have an idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants