Allowing individual server settings to be configured using environmen… #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! First I thought people could use a custom template, but that would force them to build their own docker image etc. So this is a very nice addition! I'll merge it during the day. |
|
In case you find the time, it would be cool if you could add some sample to the readme file so people will know about this. |
|
Sorry for the delay. I pushed up a simple pr with docs to #15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t variables
Let me know if there is anything else you would like for this PR or you don't think it is a fit for this project.
Motivation
We want to adjust some of the NGINX settings on a per host basis. For example, we want to increase the upload size for a registry.
With this PR we could then set
NGINX_GEN_client_max_body_sizeto10min order to setclient_max_body_size 10m;on the server.Testing
Tested with against our internal ECS cluster.