Improvements to Website #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for codeuino processing. Building with commit 8d8fa87 https://app.netlify.com/sites/codeuino/deploys/5f536ed96fe64f0007443287 |
ksraj123
force-pushed
the
newWebsiteDesign
branch
from
ecd0fb9 to
fe451ac
Compare
vaibhavdaren
reviewed
Aug 5, 2020
netlify-functions/getLikedTweets.js
Outdated
| baseURL: "https://api.twitter.com/1.1", | ||
| headers: { | ||
| Authorization: | ||
| "Bearer AAAAAAAAAAAAAAAAAAAAAIWYFwEAAAAAVXUBMcE6iCqQ16jlG0ZCkgQ4pf8%3DqqNIBmiUakni4wHCSqOobgKbPC4pwflEWJqKNdm9XWBRQm3pBC" |
There was a problem hiding this comment.
I made this an environment variable (moved it to netlify.toml). We could add that file to gitignore or provide the environment variable through settings in the netlify UI but both approaches would break the local development setup, would it be ok if we expect the contributors to get their own API key for local development?
vaibhavdaren
reviewed
Aug 5, 2020
vaibhavdaren
reviewed
Aug 5, 2020
vaibhavdaren
reviewed
Aug 5, 2020
vaibhavdaren
reviewed
Aug 5, 2020
|
@DevanshCodes Suggested changes made. Please review, Thanks. |
DevanshCodes
approved these changes
Aug 29, 2020
added text assests Multiple Improvements to website converted SVGs to material icons joinus and donate sections added added blogs added testimonials section removed redundant code medium CORS solution page transition added clickable fading blog cards updates netlify functions, twitter, medium optimizations to lambda functions testimonials update requested changes suggested changes
ksraj123
force-pushed
the
newWebsiteDesign
branch
from
fe66085 to
37fa91c
Compare
|
@DevanshCodes Hi, commits squashed, please merge. Thanks. |
Please look into the tests, they're failing. |
ksraj123
force-pushed
the
newWebsiteDesign
branch
from
41e08a2 to
37fa91c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current build can be accessed at - https://hopeful-colden-618a86.netlify.app/
List of changes made -
Pleaes provide feedback and suggestions.