Minor improvements to download API #1092
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2-towns
reviewed
Jan 31, 2025
| if extension == "": | ||
| return RestApiResponse.error(Http422, "The MIME type is not valid.") | ||
| return RestApiResponse.error( | ||
| Http422, "The MIME type '" & mimetypeVal & "' is not valid." |
There was a problem hiding this comment.
Yes it is better. You just need to update the test case "upload fails if content type is invalid" to include the mimetype value.
There was a problem hiding this comment.
Yep, just noticed this is failing now. Thanks
2-towns
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to debug a download failure and ended up adding slightly better error feedback. Also noted some dead code, which I have removed.