Prevent duplicate block transmission #1093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmega
added
Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During reliability testing (#974) block retransmission was found to cause significant delay and download failure in larger networks.
This PR prevents wantBlocks being sent for open requests for which a wantBlock has already been sent, reducing duplicates to zero.
Open issue (that already existed and hasn't been seen in testing) is that when a wantBlock is sent and the peer doesn't respond with the block, the inFlight flag is never cleared, forcing the full block-retrieval-timeout before the block can be retried.