Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumps constantine, updates curves #21

Merged
merged 3 commits into from
Jan 21, 2025
Merged

bumps constantine, updates curves #21

merged 3 commits into from
Jan 21, 2025

Conversation

benbierens
Copy link
Contributor

@benbierens benbierens commented Aug 8, 2024

Is needed to fix broken build of multihash-poseidon2 branch over in nim-libp2p.

@2-towns
Copy link
Contributor

2-towns commented Dec 2, 2024

Updated to the last version of Constantine because of a compilation error with Nim 2.X.

I added a nimble.lock file. You can use it by adding the env variable:

NIMBLE_DIR=.nimble
NIMBLE_DIR=.nimble nimble install

Or by passing the command arguments:

nimble c --nimbleDir=.nimble

Signed-off-by: Arnaud <arnaud@status.im>
@2-towns 2-towns force-pushed the bump-constantine-gcc14 branch from 9d4b456 to f5a3511 Compare December 4, 2024 12:02
@2-towns
Copy link
Contributor

2-towns commented Dec 13, 2024

Note that Constantine removed the support to the Nim version 1.6.x

@mratsim
Copy link

mratsim commented Jan 17, 2025

Note that I dropped explicitly testing in CI the 1.6.x series but it should still compile.

The reason why is that I couldn't compile this Ethereum Foundation funded PR to accelerate Secret Leader Election: mratsim/constantine#485. But currently it's not used anywhere.

@bkomuves bkomuves merged commit 7749c36 into main Jan 21, 2025
4 checks passed
@bkomuves bkomuves deleted the bump-constantine-gcc14 branch January 21, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants