Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preventDefaultEvents support added #1473

Closed
wants to merge 9 commits into from
Closed

preventDefaultEvents support added #1473

wants to merge 9 commits into from

Conversation

robonetphy
Copy link
Member

resolve #1433

@robonetphy robonetphy requested a review from neSpecc December 11, 2020 23:03
neSpecc
neSpecc reviewed Dec 12, 2020
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is not related to CodeMirror. It just a helpful thing, that can be used for many tools.

types/tools/block-tool.d.ts Outdated Show resolved Hide resolved
types/tools/block-tool.d.ts Outdated Show resolved Hide resolved
src/components/modules/blockEvents.ts Outdated Show resolved Hide resolved
@robonetphy robonetphy changed the title codemirror support added preventDefaultEvents support added Dec 13, 2020
@robonetphy robonetphy requested a review from neSpecc December 14, 2020 17:55
neSpecc
neSpecc reviewed Dec 22, 2020
View reviewed changes
src/components/modules/tools.ts Outdated Show resolved Hide resolved
src/components/modules/tools.ts Outdated Show resolved Hide resolved
robonetphy and others added 2 commits December 22, 2020 22:54
@robonetphy @neSpecc
Apply suggestions from code review
744924b 
Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
@robonetphy
preventDefaultEvent Removed
524fe7c
@robonetphy robonetphy requested a review from neSpecc December 22, 2020 18:00
neSpecc
neSpecc requested changes Jan 26, 2021
View reviewed changes
src/components/modules/blockEvents.ts Outdated Show resolved Hide resolved
example/example-codemirror.html Outdated Show resolved Hide resolved
types/tools/block-tool.d.ts Outdated Show resolved Hide resolved
@robonetphy robonetphy marked this pull request as ready for review February 1, 2021 16:32
@robonetphy robonetphy requested a review from ranemihir February 1, 2021 16:34
hata6502
hata6502 suggested changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@hata6502 hata6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write docs/CHANGELOG.md.

@hata6502
Copy link
Contributor

hata6502 commented Feb 3, 2021

@neSpecc
I think the following issue should be resolved first of all.
#1386

@robonetphy robonetphy requested a review from neSpecc February 3, 2021 16:49
@robonetphy robonetphy requested review from neSpecc and removed request for neSpecc February 18, 2021 16:30
@neSpecc
Copy link
Member

neSpecc commented Mar 16, 2021 •
edited
Loading

This feature is not required since we've fixed the original issue #1563

Thanks @robonetphy @hata6502 @khaydarov

@neSpecc neSpecc closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hata6502 hata6502 hata6502 requested changes

@gohabereg gohabereg Awaiting requested review from gohabereg gohabereg is a code owner

@khaydarov khaydarov Awaiting requested review from khaydarov

@ranemihir ranemihir Awaiting requested review from ranemihir

@neSpecc neSpecc Awaiting requested review from neSpecc neSpecc is a code owner

Assignees
No one assigned
Labels
freezed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent Default Event For CodeMirror Like Application💡
3 participants
@robonetphy @hata6502 @neSpecc