New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary window promise from Initialisation test. #1488

Merged

neSpecc merged 1 commit into codex-team:next from ranemihir:fix-init-test-remove-window-promise

Feb 18, 2021

Contributor

ranemihir commented Dec 24, 2020 •

edited

Loading

Removes the unnecessary promise to access the browser window object which is not used.

it('should create a visible UI', () => {
      cy.window().then((window) => {
        /**
         * Assert if created instance is visible or not.
         */
        cy.get('[data-cy=editorjs]')
          .get('div.codex-editor')
          .should('be.visible');
});

In this test the cy.window().then() promise is unnecessary as window object is not actually being used.


          Remove unnecessary window promise

18d7908

ranemihir requested review from gohabereg, khaydarov and neSpecc as code owners

December 24, 2020 17:30

neSpecc approved these changes

View reviewed changes

khaydarov approved these changes

View reviewed changes

neSpecc merged commit 50cbc4d into codex-team:next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet