Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring based on LGTM #1635

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Refactoring based on LGTM #1635

merged 3 commits into from
Apr 8, 2021

Conversation

hata6502
Copy link
Contributor

@hata6502 hata6502 commented Apr 8, 2021

@hata6502 hata6502 marked this pull request as draft April 8, 2021 15:13
@hata6502
Copy link
Contributor Author

hata6502 commented Apr 8, 2021

Sorry!, this PR fixes LGTM warnings, but it increases ESLInt warnings 😅

$ yarn lint:fix
/home/hata6502/editor.js/src/components/block/index.ts
  215:0  warning  The type 'BlockToolConstructable' is undefined  jsdoc/no-undefined-types
  216:0  warning  The type 'ToolSettings' is undefined            jsdoc/no-undefined-types

@hata6502 hata6502 marked this pull request as ready for review April 8, 2021 15:23
@hata6502
Copy link
Contributor Author

hata6502 commented Apr 8, 2021

Fixed jsdoc/no-undefined-types.
042dcb8

@hata6502 hata6502 requested review from neSpecc and gohabereg April 8, 2021 15:25
@gohabereg gohabereg merged commit 9cdda11 into codex-team:next Apr 8, 2021
@hata6502 hata6502 deleted the bugfix/lgtm branch April 9, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gohabereg gohabereg gohabereg approved these changes

@neSpecc neSpecc neSpecc approved these changes

@khaydarov khaydarov Awaiting requested review from khaydarov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hata6502 @neSpecc @gohabereg