Skip to content
This repository has been archived by the owner on Oct 2, 2018. It is now read-only.

Security Issues #99

Closed
3 tasks done
ferndot opened this issue Jun 25, 2013 · 8 comments
Closed
3 tasks done

Security Issues #99

ferndot opened this issue Jun 25, 2013 · 8 comments

Comments

@ferndot
Copy link
Member

ferndot commented Jun 25, 2013

  • Txt content needs to be sanitized for html tags and entities before being wrapped in the <pre> tag. And then you need to convert it /back/ to pure text again - i.e. if you type &amp; it should be saved as exactly that in the txt file. At the moment its saved html-style encoded.
  • I can't see why you need the browser permission for just displaying an internal about page - you'd only need it for displaying external content and providing navigation features. An iframe would work as an alternative and you wouldn't need the (potentially dangerous) browser permission.

potential issues:

  • I can't see its used, but run_prettify.js isn't going to work - /resources/google-code-prettify/run_prettify.js#L179 - creates inline script tags which are blocked by the CSP.
@ghost ghost assigned ferndot Jun 25, 2013
@logan-r
Copy link
Member

logan-r commented Jun 26, 2013

Can I work on the first issue?

@HR
Copy link
Member

HR commented Jun 26, 2013

Yes and another thing about issue is all the formatting appears when you paste text. For example paste piece of text that is italic and has font "moz", it will stay the same when you paste it into firetext and this creates an error that prevents the document from being saved (probably because back end is written in HTML like he said above as well).

@ferndot
Copy link
Member Author

ferndot commented Jun 26, 2013

@Logi0 please take the first one :)

ferndot pushed a commit that referenced this issue Jun 26, 2013
ferndot pushed a commit that referenced this issue Jul 3, 2013
@logan-r
Copy link
Member

logan-r commented Jul 3, 2013

For the first issue we could use document.createTextNode().

@ferndot
Copy link
Member Author

ferndot commented Jul 3, 2013

Can you fix it then?

@HR
Copy link
Member

HR commented Jul 6, 2013

How long is this going to take?

@ferndot
Copy link
Member Author

ferndot commented Jul 6, 2013

Too long 😢

@ferndot ferndot closed this as completed in 4836f90 Jul 7, 2013
@ferndot
Copy link
Member Author

ferndot commented Jul 7, 2013

Yay!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants