You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As highlighted in #252 there are good chances that API can become inconsistent if certain methods aren't named properly and such mistakes are missed in the review process. So, a solution should be proposed to solve this problem satisfying the following conditions,
A set of certain methods should be implemented(i.e., shouldn't raise NotImplementedError) in every class. If some methods from the given set of methods isn't implemented then that should be detected in CI.
The solutions should be simple enough such that it can be easily ported to C++11.
Description of the problem
As highlighted in #252 there are good chances that API can become inconsistent if certain methods aren't named properly and such mistakes are missed in the review process. So, a solution should be proposed to solve this problem satisfying the following conditions,
NotImplementedError
) in every class. If some methods from the given set of methods isn't implemented then that should be detected in CI.One of the approaches is described at #252 (comment)
Example of the problem
References/Other comments
Please discuss your approach first rather than jumping to code directly.
The text was updated successfully, but these errors were encountered: