Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality tests for public API #255

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Conversation

czgdp1807
Copy link
Member

@czgdp1807 czgdp1807 commented Apr 10, 2020

References to other Issues or PRs or Relevant literature

Closes #254

Brief description of what is fixed or changed

Tests that if a method which is must for child class is there in it rather than being accessed from parent class. Uses MRO to find out where the required method is.

Other comments

@czgdp1807 czgdp1807 marked this pull request as ready for review April 20, 2020 09:56
@czgdp1807 czgdp1807 removed the Please take over PRs that can be continued by anyone. label Apr 20, 2020
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #255 into master will increase coverage by 0.227%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #255       +/-   ##
=============================================
+ Coverage   98.546%   98.774%   +0.227%     
=============================================
  Files           24        23        -1     
  Lines         2202      2285       +83     
=============================================
+ Hits          2170      2257       +87     
+ Misses          32        28        -4     
Impacted Files Coverage Δ
pydatastructs/graphs/adjacency_list.py 100.000% <100.000%> (ø)
pydatastructs/graphs/adjacency_matrix.py 100.000% <100.000%> (ø)
pydatastructs/linear_data_structures/arrays.py 100.000% <100.000%> (ø)
...datastructs/linear_data_structures/linked_lists.py 99.596% <100.000%> (-0.018%) ⬇️
...ts/miscellaneous_data_structures/binomial_trees.py 100.000% <100.000%> (ø)
...ucts/miscellaneous_data_structures/disjoint_set.py 100.000% <100.000%> (ø)
...datastructs/miscellaneous_data_structures/queue.py 100.000% <100.000%> (ø)
...datastructs/miscellaneous_data_structures/stack.py 100.000% <100.000%> (ø)
pydatastructs/trees/binary_trees.py 97.094% <100.000%> (+0.060%) ⬆️
pydatastructs/trees/heaps.py 97.927% <100.000%> (+0.089%) ⬆️
... and 6 more

Impacted file tree graph

@czgdp1807 czgdp1807 merged commit 059ad08 into codezonediitj:master Apr 20, 2020
@czgdp1807 czgdp1807 deleted the quality_tests branch April 20, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforcing implementations of certain methods in classes
1 participant