TreeNode check added for heap.py #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=============================================
+ Coverage 98.173% 98.176% +0.002%
=============================================
Files 21 21
Lines 1588 1590 +2
=============================================
+ Hits 1559 1561 +2
Misses 29 29
|
czgdp1807
reviewed
Mar 11, 2020
czgdp1807
reviewed
Mar 11, 2020
czgdp1807
reviewed
Mar 11, 2020
czgdp1807
reviewed
Mar 11, 2020
Comment on lines
32
to
33
| l = max_heap.heap[0].left | ||
| l = max_heap.heap[0].right |
There was a problem hiding this comment.
I might have accidentally removed them. It was showing a warning if I remember correctly
There was a problem hiding this comment.
I think the first line can be removed safely, though do it in a different PR.
There was a problem hiding this comment.
The variable is never being used, so idk whats the point of having it.
There was a problem hiding this comment.
Sure, feel free to remove it in a separate PR.
czgdp1807
reviewed
Mar 11, 2020
czgdp1807
reviewed
Mar 11, 2020
czgdp1807
reviewed
Mar 11, 2020
Added new line at the end Co-Authored-By: Gagandeep Singh <gdp.1807@gmail.com>
Co-Authored-By: Gagandeep Singh <gdp.1807@gmail.com>
Co-Authored-By: Gagandeep Singh <gdp.1807@gmail.com>
Co-Authored-By: Gagandeep Singh <gdp.1807@gmail.com>
Co-Authored-By: Gagandeep Singh <gdp.1807@gmail.com>
Co-Authored-By: Gagandeep Singh <gdp.1807@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of what is fixed or changed
Doc string of heap.py is updated.
relevant test added.
Other comments
Previous PR was messed up, this one should work