Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement in sorting algorithms #216

Merged
merged 2 commits into from
Mar 25, 2020

Conversation

czgdp1807
Copy link
Member

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Sorting algorithms now do not disturb positions which are out of scope of start and end. None is treated is infinite value. A custom comparator is introduced for the same.

ping @HarsheetKakar

Other comments

.. [1] #207 (comment)

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #216 into master will increase coverage by 0.020%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #216       +/-   ##
=============================================
+ Coverage   96.876%   96.897%   +0.020%     
=============================================
  Files           24        24               
  Lines         1921      1934       +13     
=============================================
+ Hits          1861      1874       +13     
  Misses          60        60               
Impacted Files Coverage Δ
pydatastructs/linear_data_structures/algorithms.py 100.000% <100.000%> (ø)
pydatastructs/linear_data_structures/arrays.py 100.000% <100.000%> (ø)
pydatastructs/utils/misc_util.py 90.740% <100.000%> (+0.740%) ⬆️

Impacted file tree graph

@czgdp1807 czgdp1807 merged commit 961d296 into codezonediitj:master Mar 25, 2020
@czgdp1807 czgdp1807 deleted the merge_sort branch March 25, 2020 16:14
@HarsheetKakar
Copy link
Contributor

Thanks it makes work a lot easier

@HarsheetKakar
Copy link
Contributor

Can we change None to another Node type so that we can overload its operators which will remove the need for _comp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants