Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter order changed in docstrings #275

Merged
merged 1 commit into from
May 6, 2020

Conversation

Ryand1234
Copy link
Contributor

@Ryand1234 Ryand1234 commented May 6, 2020

References to other Issues or PRs or Relevant literature

Fixes #251

Brief description of what is fixed or changed

Order of parameter in docstring now matches their prototype function/class.

Other comments

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #275 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #275   +/-   ##
=========================================
  Coverage   98.810%   98.810%           
=========================================
  Files           23        23           
  Lines         2353      2353           
=========================================
  Hits          2325      2325           
  Misses          28        28           
Impacted Files Coverage Δ
...datastructs/linear_data_structures/linked_lists.py 99.596% <ø> (ø)
pydatastructs/trees/binary_trees.py 97.364% <ø> (ø)
pydatastructs/trees/heaps.py 97.927% <ø> (ø)
pydatastructs/trees/m_ary_trees.py 91.176% <ø> (ø)
pydatastructs/trees/space_partitioning_trees.py 97.656% <ø> (ø)
pydatastructs/utils/misc_util.py 100.000% <ø> (ø)

Impacted file tree graph

@czgdp1807
Copy link
Member

Looks good, some minor changes are needed. Are you a GSSoC, 2020 participant.

@czgdp1807 czgdp1807 added the documentation Improvements or additions to documentation label May 6, 2020
@Ryand1234
Copy link
Contributor Author

No, I'm not a participant

@Ryand1234
Copy link
Contributor Author

What changes are needed?

@czgdp1807
Copy link
Member

IMO, changes would be too subtle. Merging directly.

@czgdp1807 czgdp1807 merged commit 2284b55 into codezonediitj:master May 6, 2020
@czgdp1807
Copy link
Member

Thanks.

@Ryand1234 Ryand1234 deleted the parameter_order branch May 6, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct order of parameters in doc strings
2 participants