Do not invoke setupy.py directly. #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invoking setup.py directly is not the best way to install a package from source. See one of the most recent blog about this: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html This updates the readme to invoke pip, and use `python -m pip` to make sure that the pip which is invoked is the one from the current Python. i'm also happy to make it `python3 -m pip`, but these days python points to python 3 most of the time.
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
=========================================
Coverage 98.611% 98.611%
=========================================
Files 27 27
Lines 3530 3530
=========================================
Hits 3481 3481
Misses 49 49 |
|
Thanks for the PR. |
czgdp1807
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoking setup.py directly is not the best way to install a package from
source. See one of the most recent blog about this:
https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html
This updates the readme to invoke pip, and use
python -m pipto makesure that the pip which is invoked is the one from the current Python.
i'm also happy to make it
python3 -m pip, but these days python pointsto python 3 most of the time.
References to other Issues or PRs or Relevant literature
Brief description of what is fixed or changed
Other comments