-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the tests for python and C++ and combined test report into unified test report #574
base: main
Are you sure you want to change the base?
Conversation
@czgdp1807 |
- name: Upload Coverage | ||
uses: codecov/codecov-action@v3 | ||
with: | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
directory: ./coverage/reports/ | ||
env_vars: OS,PYTHON | ||
fail_ci_if_error: false | ||
files: ./merged-coverage.xml | ||
files: ./coverage-python.xml,./coverage-cpp.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to do the same thing locally? Can you show a screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have arrived at a preliminary solution for merging Python and C++ coverage reports using Codecov, based on their official documentation https://docs.codecov.com/docs/github-4a-merging-reports.
To further validate this solution, I plan to develop and test it locally by utilizing a Codecov API key. I will ensure comprehensive testing and provide you with an update on the results by the end of the week sir .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually there should be a way to do it without Codecov. This is indeed tough to achieve. So if you want to take other issues while parallelly working on it, feel free to do so.
Brief description of what is fixed or changed
Integrated unified testing for Python and C++ components.
Implemented combined coverage report generation.
Improved CI pipeline with coverage reporting and uploads to Codecov.
Other comments
Combined reports can now be found under unified-reports/html.
Feedback from mentors has been incorporated into the changes.