Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the tests for python and C++ and combined test report into unified test report #574

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nagajaideep
Copy link
Contributor

Brief description of what is fixed or changed

Integrated unified testing for Python and C++ components.
Implemented combined coverage report generation.
Improved CI pipeline with coverage reporting and uploads to Codecov.

Other comments

Combined reports can now be found under unified-reports/html.
Feedback from mentors has been incorporated into the changes.

@nagajaideep
Copy link
Contributor Author

@czgdp1807
hello sir can you please check this method of the solution for merging the Python and C++ reports into a single report

- name: Upload Coverage
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
directory: ./coverage/reports/
env_vars: OS,PYTHON
fail_ci_if_error: false
files: ./merged-coverage.xml
files: ./coverage-python.xml,./coverage-cpp.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to do the same thing locally? Can you show a screenshot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have arrived at a preliminary solution for merging Python and C++ coverage reports using Codecov, based on their official documentation https://docs.codecov.com/docs/github-4a-merging-reports.

To further validate this solution, I plan to develop and test it locally by utilizing a Codecov API key. I will ensure comprehensive testing and provide you with an update on the results by the end of the week sir .

Copy link
Member

@czgdp1807 czgdp1807 Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there should be a way to do it without Codecov. This is indeed tough to achieve. So if you want to take other issues while parallelly working on it, feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants