-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed import from __future__ #58
Conversation
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
============================================
- Coverage 98.177% 98.17% -0.008%
============================================
Files 19 19
Lines 1262 1257 -5
============================================
- Hits 1239 1234 -5
Misses 23 23
|
There are still some files which are still having imports |
Why closed? |
I will fix this and then make a new pull request sooner
…On Sat, Dec 21, 2019 at 9:20 PM Gagandeep Singh ***@***.***> wrote:
Why closed?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#58?email_source=notifications&email_token=AM43FGOAGWKMXIXMKCSISN3QZY3N3A5CNFSM4J6GWBKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHO6PRY#issuecomment-568190919>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM43FGMVGL5QIDIRCKDDNMDQZY3N3ANCNFSM4J6GWBKA>
.
|
Rather than making a new pull request, update this only by pushing changes here. |
You can merge master branch(after updating it by pulling the changes) into your branch and resume working on it. |
How shall i update my forked branch with you master branch...Mine is still 2commits behind your master branch |
Follow the steps given below,
Here |
And how can i update the same pull request?? |
I think it's updated now plz take a look! i have made some Changes in Test Branches (i.e. removed Future imports from 5 Files) |
Make changes to |
Yes, it's updated. |
I think you forgot to remove the line from https://github.com/codezonediitj/pydatastructs/blob/master/pydatastructs/trees/binary_trees.py |
I think I have removed the line from all the files and there is no more such lines left in my latest commit already! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed all such line...
Fixes #56
Brief description of what is fixed or changed
Removed import from future as it was unnecessary for python 3
Other comments